Conversation
akofink
left a comment
akofink
left a comment
There was a problem hiding this comment.
Looks good - a couple minor comments.
|
|
||
| def text | ||
| @parsed_xml.text unless sub | ||
| end |
There was a problem hiding this comment.
Let's put this on the XmlNode as it applies to any xml node.
lib/openscap_parser/subs.rb
Outdated
| Sub.new(parsed_xml: sub_node) | ||
| end | ||
|
|
||
| def sub_node |
There was a problem hiding this comment.
There can be 0 to n sub nodes according to the spec. IMO this should be pluralized
|
Multiple subs for one fixed are now parsed correctly. |
akofink
left a comment
akofink
left a comment
There was a problem hiding this comment.
Works great. Optionally add the missing attributes - but we can also add them later.
| def complexity | ||
| @complexity ||= @parsed_xml['complexity'] | ||
| end | ||
|
|
There was a problem hiding this comment.
Should we include disruption and strategy?
| def id | ||
| @id ||= @parsed_xml['idref'] | ||
| end | ||
|
|
There was a problem hiding this comment.
Should we add use here?
the xccdf:sub element MAY have a use attribute that indicates whether the xccdf:Value element's title or value should replace the xccdf:sub element.
xprazak2
force-pushed
the
parse-fixes
branch
from
bab7e89 to
baba20c
Compare
|
I rebased and added parsing for |
2 participants
No description provided.